Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary model for open boundaries #577

Merged
merged 9 commits into from
Jul 19, 2024

fix

7f1d620
Select commit
Loading
Failed to load commit list.
Merged

Boundary model for open boundaries #577

fix
7f1d620
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 19, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 74.19355% with 32 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b3219cb). Learn more about missing BASE report.

Files Patch % Lines
...oundary/open_boundary/method_of_characteristics.jl 73.03% 24 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 83.33% 5 Missing ⚠️
src/visualization/write2vtk.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage        ?   69.73%           
=======================================
  Files           ?       76           
  Lines           ?     4573           
  Branches        ?        0           
=======================================
  Hits            ?     3189           
  Misses          ?     1384           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.