Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cluster-name in ingress/egress rules #3

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Added support for cluster-name in ingress/egress rules #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gcn.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
]
secondary_ranges = {
# has to be passed in interpolation otherwise it give error
"${local.private_subnet_name}" = var.network_vpc_secondary_ranges

Check warning on line 28 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (ubuntu-latest) 

Interpolation-only expressions are deprecated in Terraform v0.12.14

Check warning on line 28 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (macos-latest) 

Interpolation-only expressions are deprecated in Terraform v0.12.14

Check warning on line 28 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (windows-latest) 

Interpolation-only expressions are deprecated in Terraform v0.12.14
}
ingress_rules = [
{
name = "ingress-allow-http-https"
name = "${local.network_name}-ingress-allow-http-https"
description = "Allow port 80 and 443"
source_ranges = ["0.0.0.0/0"]
allow = [
Expand All @@ -40,7 +40,7 @@
]
},
{
name = "ingress-allow-internal"
name = "${local.network_name}-ingress-allow-internal"
description = "Allow all ports inside a subnet"
source_ranges = [var.private_subnet_cidr]
allow = [
Expand All @@ -52,7 +52,7 @@
]
egress_rules = [
{
name = "egress-allow-all"
name = "${local.network_name}-egress-allow-all"
description = "Allow egress"
source_ranges = ["0.0.0.0/0"]
destination_ranges = ["0.0.0.0/0"]
Expand All @@ -68,7 +68,7 @@
]
routes = [
{
name = "egress-internet"
name = "${local.network_name}-egress-internet"
description = "Route through IGW to access internet"
destination_range = "0.0.0.0/0"
tags = "egress-inet"
Expand All @@ -78,7 +78,7 @@
shared_vpc_host = false
}

resource "time_sleep" "wait_2_mins" {

Check warning on line 81 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (ubuntu-latest) 

Missing version constraint for provider "time" in `required_providers`

Check warning on line 81 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (macos-latest) 

Missing version constraint for provider "time" in `required_providers`

Check warning on line 81 in gcn.tf

View workflow job for this annotation

GitHub Actions / tflint (windows-latest) 

Missing version constraint for provider "time" in `required_providers`
count = var.shim ? 0 : 1
depends_on = [module.network[0]]

Expand Down
Loading