Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133932 / 25.10 / Ease of use improvements for ISO uploads #11507

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

bvasilenko
Copy link
Contributor

Testing:

You'll find TODO list in the ticket.

Item 1:

See replication steps in the ticket. The problem was in the common component ix-file-input. I fixed it.

Item 2:

Replication steps:

  1. User click Select ISO button, which is initially empty
  2. User uploads .iso file
  3. User closes the Volumes modal window
  4. User clicks Select ISO button again
  5. User uploads exactly same .iso file

Expected result: front-end does pre-validation and shows message immediately, without uploading the file.

Item 3:

Expected result: reporting of the upload progress ration in percentage 0% ... 100%

@bvasilenko bvasilenko requested a review from a team as a code owner February 7, 2025 07:13
@bvasilenko bvasilenko requested review from undsoft and removed request for a team February 7, 2025 07:13
@bugclerk
Copy link
Contributor

bugclerk commented Feb 7, 2025

@bugclerk bugclerk changed the title Ease of use improvements for ISO uploads NAS-133932 / 25.10 / Ease of use improvements for ISO uploads Feb 7, 2025
@undsoft undsoft removed the backport-25.04-BETA.1 Fangtooth Beta label Feb 7, 2025
@undsoft undsoft added the backport-25.04-BETA.1 Fangtooth Beta label Feb 7, 2025
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provides better feedback in the UI, thanks.

@bugclerk
Copy link
Contributor

bugclerk commented Feb 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants