Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): add skeleton for v2 search #163

Closed
wants to merge 5 commits into from

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Sep 19, 2024

Description

This PR introduces a skeleton page for v2 search (relates to #157). Note that this is a WIP and not feature complete.

Screenshot 2024-09-19 at 1 54 46 PM

Screenshot 2024-09-19 at 1 54 56 PM

Changes

  • Add new Search page component
  • Add new route for /search

TBD / To Do / In Progress

  • Global search functionality for all components. Normally I might suggest using React context for global-style search, but if we're not sure whether we'll be going with dedicated pages or tabs for each searchable component, then I'll just leave it like this for now until we decide we need it. In this case, we will need to lift the state up to the common ancestral parent, search.tsx, and pass them down as props. @carlosthe19916 what do you think?
  • Unit tests with mocks
  • E2E tests

@carlosthe19916 carlosthe19916 mentioned this pull request Sep 26, 2024
@carlosthe19916
Copy link
Member

@kahboom this PR #163 was based on top of the current PR so I'm going to close this one as the other PR has been merged

@kahboom kahboom deleted the 157-v2-skeleton branch October 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants