Update nob_file_exists to distinguish between errors on windows. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update nob_file_exists to distinguish between "does not exists" and other windows errors (todo). Couldn't get nob to compile and thought #if _WIN32 was the cause, forked already, and then noticed that it doesn't matter, it was something on my end. So I decided to just go ahead and fix something, and #ifdef _WIN32 is now just a consistancy/cleanliness bonus. Had some trouble with FormatMessage, so helped myself to the answer from stackoverflow.com/questions/455434
rexim
reviewed
Feb 6, 2024
Just made a little function and started blasting.
Upgrade windows error handling
That wasn't supposed to be in there...
|
So, anyway, after I took a second look at everything I noticed more of those GetLastError's, made a little function and just started blasting. Tested all of them too, except those more annoying nob_proc_wait ones. |
When implementing previous changes to windows error reporting, exit status of user ran commands would get ran through nob_get_last_windows_error_name and return erroneous windows error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update nob_file_exists to distinguish between "does not exists" and other windows errors (todo).
Couldn't get nob to compile and thought #if _WIN32 was the cause, forked already, and then noticed that it doesn't matter, it was something on my end. So I decided to just go ahead and fix something, and #ifdef _WIN32 is now just a consistancy/cleanliness bonus.
Had some trouble with FormatMessage, so helped myself to the answer from stackoverflow.com/questions/455434