Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nob_file_exists to distinguish between errors on windows. #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update nob_file_exists to distinguish between errors on windows. #72

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
347dba1
Update nob_file_exists to distinguish between errors on windows.
wysiengnik11 Jan 21, 2024
473e551
Upgrade windows error handling
wysiengnik11 Feb 6, 2024
c6ddd2f
Merge pull request #1 from wysiengnik11/wysiengnik11-patch-1
wysiengnik11 Feb 6, 2024
007daa2
Update nob.h
wysiengnik11 Feb 6, 2024
24994c9
Roll back an accidental over-eagarness
wysiengnik11 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/nob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ int nob_file_exists(const char *file_path);

// TODO: add MinGW support for Go Rebuild Urself™ Technology
#ifndef NOB_REBUILD_URSELF
# if _WIN32
# ifdef _WIN32
# if defined(__GNUC__)
# define NOB_REBUILD_URSELF(binary_path, source_path) "gcc", "-o", binary_path, source_path
# elif defined(__clang__)
Expand Down Expand Up @@ -1054,10 +1054,25 @@ bool nob_sv_eq(Nob_String_View a, Nob_String_View b)
// -1 - error while checking if file exists. The error is logged
int nob_file_exists(const char *file_path)
{
#if _WIN32
// TODO: distinguish between "does not exists" and other errors
#ifdef _WIN32
DWORD dwAttrib = GetFileAttributesA(file_path);
return dwAttrib != INVALID_FILE_ATTRIBUTES;
if (dwAttrib == INVALID_FILE_ATTRIBUTES) {
if (GetLastError() == 2) return 0;
wysiengnik11 marked this conversation as resolved.
Show resolved Hide resolved

LPTSTR errorText = NULL;
FormatMessage(
FORMAT_MESSAGE_FROM_SYSTEM
|FORMAT_MESSAGE_ALLOCATE_BUFFER
|FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, GetLastError(),
MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
(LPTSTR)&errorText, 0, NULL);

nob_log(NOB_ERROR, "Could not check if file %s exists: %s", file_path, errorText);
LocalFree(errorText);
return -1;
}
return 1;
#else
struct stat statbuf;
if (stat(file_path, &statbuf) < 0) {
Expand Down