This repository has been archived by the owner on Apr 8, 2022. It is now read-only.
Fixes to catch Sketch API change and workaround CocoaScript bug #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there I would love to try this plug in but when export as zip no file is produced. I am running Sketch 47.1. Is there an updated plugin file for this at all? Many thanks - Emma |
MForever78
added a commit
that referenced
this pull request
Nov 20, 2017
Fixes to catch Sketch API change and workaround CocoaScript bug
nailgilaziev
added a commit
to nailgilaziev/AppIconMultiplier
that referenced
this pull request
Dec 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
[NSArray arrayWithObjects]stops working on 10.13. This is a bug caused by CocoaScript itself. Reference on: NSArray.arrayWithObjects and NSDictionary.dictionaryWithObjectsAndKeys not working in 10.13 ccgus/CocoaScript#48 . We can workaround this bug by using[NSArray arrayWithArray]instead.layer.style().fill(). It now calledlayer.style.fills()and returns an array offillobjects. We should just use the first element of this array and call theCSSAttributeStringmethod.Tested locally and is able to export.