Improve i18n ci #10209
Merged
Improve i18n ci #10209
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the i18n translation workflow to streamline the branch setup process for handling translations in the Twenty project.
- Simplified i18n branch setup in
.github/workflows/i18n-push.yamlusing a more concise two-command approach with fallback handling - Added error tolerance for missing remote i18n branch with
git fetch origin i18n || true - Introduced unified branch checkout/creation with
git checkout -B i18n origin/i18n || git checkout -b i18n
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+28
to
+29
| git fetch origin i18n || true | ||
| git checkout -B i18n origin/i18n || git checkout -b i18n |
There was a problem hiding this comment.
logic: This new approach could silently fail if the remote branch exists but is inaccessible. Consider adding error handling or logging.
| git merge origin/main | ||
| fi | ||
| git fetch origin i18n || true | ||
| git checkout -B i18n origin/i18n || git checkout -b i18n |
There was a problem hiding this comment.
logic: The new implementation no longer merges with main, which could lead to conflicts if the i18n branch falls behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.