Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n ci #10209

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Improve i18n ci #10209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/i18n-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,8 @@ jobs:

- name: Setup i18n branch
run: |
if ! git ls-remote --heads origin i18n | grep i18n; then
git checkout -b i18n
else
git fetch origin i18n
git checkout i18n
git merge origin/main
fi
git fetch origin i18n || true
git checkout -B i18n origin/i18n || git checkout -b i18n
Comment on lines +28 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This new approach could silently fail if the remote branch exists but is inaccessible. Consider adding error handling or logging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The new implementation no longer merges with main, which could lead to conflicts if the i18n branch falls behind.


- name: Install dependencies
uses: ./.github/workflows/actions/yarn-install
Expand Down
Loading