Enforce AbstractBinary for all binary operators #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Nov 29, 2024
| namespace Twig\Node\Expression; | ||
|
|
||
| /** | ||
| * Interface implemented by n-ary operators for n > 1. |
There was a problem hiding this comment.
This interface can be defined on 1-ary operators, but that would not make sense.
|
|
||
| $stream->expect(Token::PUNCTUATION_TYPE, ':', 'A type name must be followed by a colon (:)'); | ||
| if ($stream->nextIf(Token::OPERATOR_TYPE, '?:')) { |
There was a problem hiding this comment.
There is an ambiguity when using ?: in foo? : boolean.
|
I'll update all the PHPdoc in 3.x after this PR (and then do the same in 4.x) |
stof
reviewed
Nov 29, 2024
fabpot
force-pushed
the
ternary-operator
branch
4 times, most recently
from
b792ee5 to
a618a4f
Compare
stof
reviewed
Nov 29, 2024
fabpot
force-pushed
the
ternary-operator
branch
from
a618a4f to
4f8ba93
Compare
This was referenced Dec 2, 2024
xabbuh
added a commit
to symfony/symfony
that referenced
this pull request
Dec 2, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [TwigBridge] fix Twig 3.17 compatibility | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see twigphp/Twig#4482 Commits ------- ac4ca46 fix Twig 3.17 compatibility
fabpot
added a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.