Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploying esco-hamburger-menu from quickstart #239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jgribonvald
Copy link
Contributor

@jgribonvald jgribonvald commented Oct 18, 2018

Checklist
Description of change

Here is a commit on how to deploy the esco-content-menu.

How would you like to include it ? Adding only a documentation into esco-content-menu wc ? or like that ?
After I'm agree the script into the jsp invoker can be reviewed, but I did like that as I wasn't able to deploy it with the menu button component, I need to generate the button directly into the body and adding an event javascript to open/hidde the page.

So this commit is in WIP more for a feedback ! (And is independent of solving font issues)

@jgribonvald jgribonvald changed the title WIP: deploying esco-content-menu from quickstart [WIP] feat: deploying esco-content-menu from quickstart Oct 18, 2018
@ChristianMurphy
Copy link
Member

related to #220

@jgribonvald jgribonvald force-pushed the WIP_content_menu branch 2 times, most recently from 73e7188 to 0e82d82 Compare December 11, 2018 12:19
@jgribonvald jgribonvald changed the title [WIP] feat: deploying esco-content-menu from quickstart [WIP] feat: deploying esco-hamburger-menu from quickstart Dec 11, 2018
@jgribonvald jgribonvald changed the title [WIP] feat: deploying esco-hamburger-menu from quickstart feat: deploying esco-hamburger-menu from quickstart Jan 30, 2019
@jgribonvald
Copy link
Contributor Author

I think that I can't improve more things inside this PR, or tell me what do do ! (I shown how it was easy to deploy it !)
So you have the rigth to close this PR, or ???
it's one way of moving from the good old one Menu, but a part is missing: the accessibility check ;)

@drewwills
Copy link
Contributor

@jgribonvald -- I'm very interested in getting the ESCO Hamburger into quickstart.

This week is pretty busy, so it's hard to look, but I do think this is a good idea.

@jgribonvald
Copy link
Contributor Author

jgribonvald commented Apr 17, 2019

As example a quick and fast way to change the welcome page:

  • you can use this same commit
  • modify the jsp in this commit with a such code (adapt properties like you want/need)
<esco-content-menu
      default-org-logo="${alternativeBanner[0]}"
      favorites-portlet-card-size="${favoritesPortletCardSize[0]}"
      grid-portlet-card-size="${gridPortletCardSize[0]}"
      hide-action-mode="${hideActionMode[0]}"
      portlet-api-url="${portletApiUrl[0]}"
      layout-api-url="${layoutApiUrl[0]}"
      organization-api-url="${organizationApiUrl[0]}"
      user-info-api-url="${userInfoApiUrl[0]}"
      :show-favorites-in-slider="false"
      debug>
      <div slot="header-buttons"></div>
      <div slot="content-user"></div>
    </esco-content-menu>
</div>

<script type="text/javascript">
  document.addEventListener("DOMContentLoaded", function(event) {
    const parent = document.getElementById("portalPageBody");
    while (parent.firstChild) {
      parent.firstChild.remove();
    }
    parent.appendChild(document.querySelector('#content-menu'));
  });
</script>

and you will be able to get a such portal content:
image

@jgribonvald
Copy link
Contributor Author

I've modified:

  • the jsp to make optional to hide the native uPortal Nav from preference portlet property hidePortalNav
  • changed the admin-dashboard to evoid to load several times the esco-content-menu lib and vuejs lib too as it's integrated from the esco-content-menu jsp on each page

I think if we want to integrate it, it can be done now.
Maybe some change should be done on the hamburger menu for Accessibility. Any help would be welcome on this part.

The MIME type is required to avoir X-Content-Type-Options: nosniff browser blocking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants