-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploying esco-hamburger-menu from quickstart #239
base: master
Are you sure you want to change the base?
Conversation
related to #220 |
73e7188
to
0e82d82
Compare
0e82d82
to
3af75c4
Compare
3af75c4
to
9878c54
Compare
I think that I can't improve more things inside this PR, or tell me what do do ! (I shown how it was easy to deploy it !) |
@jgribonvald -- I'm very interested in getting the ESCO Hamburger into quickstart. This week is pretty busy, so it's hard to look, but I do think this is a good idea. |
As example a quick and fast way to change the welcome page:
<esco-content-menu
default-org-logo="${alternativeBanner[0]}"
favorites-portlet-card-size="${favoritesPortletCardSize[0]}"
grid-portlet-card-size="${gridPortletCardSize[0]}"
hide-action-mode="${hideActionMode[0]}"
portlet-api-url="${portletApiUrl[0]}"
layout-api-url="${layoutApiUrl[0]}"
organization-api-url="${organizationApiUrl[0]}"
user-info-api-url="${userInfoApiUrl[0]}"
:show-favorites-in-slider="false"
debug>
<div slot="header-buttons"></div>
<div slot="content-user"></div>
</esco-content-menu>
</div>
<script type="text/javascript">
document.addEventListener("DOMContentLoaded", function(event) {
const parent = document.getElementById("portalPageBody");
while (parent.firstChild) {
parent.firstChild.remove();
}
parent.appendChild(document.querySelector('#content-menu'));
});
</script> |
9878c54
to
5bfa32b
Compare
5bfa32b
to
e0c0220
Compare
e0c0220
to
9c54ec9
Compare
I've modified:
I think if we want to integrate it, it can be done now. |
The MIME type is required to avoir X-Content-Type-Options: nosniff browser blocking
Checklist
Description of change
Here is a commit on how to deploy the esco-content-menu.
How would you like to include it ? Adding only a documentation into esco-content-menu wc ? or like that ?
After I'm agree the script into the jsp invoker can be reviewed, but I did like that as I wasn't able to deploy it with the menu button component, I need to generate the button directly into the body and adding an event javascript to open/hidde the page.
So this commit is in WIP more for a feedback ! (And is independent of solving font issues)