Draft Testing PR Test/increase capybara wait for asynchronous process #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capybara is timing out on tests when uploading files. The value for `default_max_wait_time` had been previously increased to 5 but that continues to make tests fail. Increasing this time will hopefully decrease failed tests due to latency in asynchronous processes.
lagoan
requested review from
ConnorSheremeta,
jefferya and
pgwillia
as code owners
lagoan
changed the title
The tests that are failing have to do with files being uploaded and the action timing out. Instead of increasing the wait time to all asynchronous process, we will localize the increased time to this action.
After uploading the files, we also need to wait more so that the application can save the entity and continue with the process
…nchronous_process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is only a test PR to review the flapping errors coming up from uploading files.
Tests are failing due to items taking too long to upload and the test suite drops them after 5 seconds. By increasing the amount of time we wait for the change we should stop seeing these errors.
What's New
This test PR should only increase the value
Capybara.default_max_wait_timeto see how it affects the tests results.Remember to request a reviewer when you submit!