Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft Testing PR Test/increase capybara wait for asynchronous process #2968

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Draft Testing PR Test/increase capybara wait for asynchronous process #2968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94f71b3
Increase capybara wait time
lagoan Sep 13, 2022
290e931
Test increase default wait time even more
lagoan Sep 14, 2022
e2f6e8f
Localize increased wait time to problematic areas
lagoan Sep 14, 2022
8ff895b
Increase wait time for item and thesis save action
lagoan Sep 14, 2022
97cbd30
Change wait time to assert_selector for h2 node
lagoan Sep 14, 2022
4311f1e
Merge branch 'origin/master' into test/increase_capybara_wait_for_as…
lagoan Sep 19, 2022
e85fea6
Merge branch 'master' into test/increase_capybara_wait_for_asynchrono…
lagoan Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/system/deposit_item_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ class DepositItemTest < ApplicationSystemTestCase
attach_file_in_dropzone(file_fixture('image-sample.jpeg'))
has_css? '.j-thumbnail'

click_on I18n.t('items.draft.save_and_continue'), wait: 5
click_on I18n.t('items.draft.save_and_continue')

# 4. Review and Deposit Form

assert_selector 'h2', text: I18n.t('items.draft.review_and_deposit_item.header')
assert_selector 'h2', text: I18n.t('items.draft.review_and_deposit_item.header'), wait: 15

click_on I18n.t('items.draft.header')

Expand Down
4 changes: 2 additions & 2 deletions test/system/deposit_thesis_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ class DepositThesisTest < ApplicationSystemTestCase
attach_file_in_dropzone(file_fixture('image-sample.jpeg'))
has_css? '.j-thumbnail'

click_on I18n.t('admin.theses.draft.save_and_continue'), wait: 5
click_on I18n.t('admin.theses.draft.save_and_continue'), wait: 15

# 4. Review and Deposit Form

assert_selector 'h2', text: I18n.t('admin.theses.draft.review_and_deposit_thesis.header')
assert_selector 'h2', text: I18n.t('admin.theses.draft.review_and_deposit_thesis.header'), wait: 15

click_on I18n.t('admin.theses.draft.header')

Expand Down