Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a C API to Neuropod #407

Open
vkuzmin-uber opened this issue Aug 6, 2020 · 2 comments · Fixed by #396 or #400
Open

Add a C API to Neuropod #407

vkuzmin-uber opened this issue Aug 6, 2020 · 2 comments · Fixed by #396 or #400

Comments

@vkuzmin-uber
Copy link
Contributor

Feature

C API

We don't expect that somebody is using C API directly. This will be used by future CGo API mostly.

Connected to #294

Describe the solution you'd like

Design is inspired by the TensorFlow C API and Uber CGO package that includes Bridge C/C++ bridge. Namely:
Internal C Headers
Public C Headers
C/C++ implementation of public and internal headers.
@VivekPanyam
Copy link
Collaborator

We don't expect that somebody is using C API directly. This will be used by future CGo API mostly.

I don't think this is accurate. We should build this API in a way where it provides a robust easy-to-use interface to use Neuropod from C (independent of the Go API)

@VivekPanyam VivekPanyam changed the title Add a C API to neuropod Add a C API to Neuropod Aug 6, 2020
This was linked to pull requests Aug 6, 2020
[C API] Initial interface proposal #396
Merged
[C API] Initial implementation #400
Merged
@vkuzmin-uber
Copy link
Contributor Author

We don't expect that somebody is using C API directly. This will be used by future CGo API mostly.

I don't think this is accurate. We should build this API in a way where it provides a robust easy-to-use interface to use Neuropod from C (independent of the Go API)

Agree, just wanted to highlight that CGO is going to be a first user really, not only.

vkuzmin-uber added a commit to vkuzmin-uber/neuropod that referenced this issue Aug 6, 2020
@vkuzmin-uber
[C API] Continue implementation
89223ce 
Continue with basic implementation of a C API for Neuropod. Issue uber#407
Added a test that loads a model and fails, runs inference successfully and fails, and verifies the name and platform.
@vkuzmin-uber vkuzmin-uber mentioned this issue Aug 6, 2020
Merged
vkuzmin-uber added a commit to vkuzmin-uber/neuropod that referenced this issue Aug 11, 2020
@vkuzmin-uber
[C API] Continue implementation
8188072 
Continue with basic implementation of a C API for Neuropod. Issue uber#407
Added a test that loads a model and fails, runs inference successfully and fails, and verifies the name and platform.
VivekPanyam pushed a commit that referenced this issue Aug 11, 2020
@vkuzmin-uber
[C API] Continue implementation (#409)
c16ad53 
### Summary:

Continue with basic implementation of a C API for Neuropod. Issue #407 

### Test Plan:

Added a test that loads a model and fails, runs inference successfully and fails, and verifies the name and platform.
@vkuzmin-uber vkuzmin-uber mentioned this issue Aug 17, 2020
Merged
VivekPanyam pushed a commit that referenced this issue Aug 19, 2020
@vkuzmin-uber
[C API] NP_GetType implementation (#419)
fd4dae6 
### Summary:
Continue with basic implementation of a C API for Neuropod. Issue #407

### Test Plan:
Added test for input and output tensors.
@vkuzmin-uber vkuzmin-uber mentioned this issue Aug 26, 2020
Merged
VivekPanyam pushed a commit that referenced this issue Aug 28, 2020
@vkuzmin-uber
[C API] NP_GetDims implementation (#422)
9992207 
### Summary:
Continue with basic implementation of a C API for Neuropod. Issue #407

### Test Plan:
Added test that test returned values of number of dims and data in dims array.
vkuzmin-uber added a commit to vkuzmin-uber/neuropod that referenced this issue Aug 31, 2020
@vkuzmin-uber
[C API] NP_GetDims implementation (uber#422)
845df8f 
### Summary:
Continue with basic implementation of a C API for Neuropod. Issue uber#407

### Test Plan:
Added test that test returned values of number of dims and data in dims array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[C API] Initial interface proposal uber/neuropod
[C API] Initial implementation uber/neuropod
2 participants
@VivekPanyam @vkuzmin-uber