[C API] Initial implementation #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuzmin-uber
approved these changes
Jul 17, 2020
vkuzmin-uber
approved these changes
Jul 17, 2020
|
|
||
| struct NP_Neuropod | ||
| { | ||
| std::unique_ptr<neuropod::Neuropod> model; |
There was a problem hiding this comment.
nit: if unique_ptr is used explicitly, it makes sense to include explicitly too. The same about shared_ptr
There was a problem hiding this comment.
Fixed (in this file and others)
| @@ -0,0 +1,24 @@ | |||
| /* Copyright (c) 2020 UATC, LLC | |||
There was a problem hiding this comment.
btw, what is UATC, is it Uber ATG abbrevation?
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 90.10% 90.03% -0.08%
==========================================
Files 77 82 +5
Lines 4741 4797 +56
==========================================
+ Hits 4272 4319 +47
- Misses 469 478 +9
Continue to review full report at Codecov.
|
VivekPanyam
changed the title
vkuzmin-uber
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
An initial basic implementation of a C API for Neuropod.
Test Plan:
Added a test that loads a model, runs inference, and verifies the output. More unit tests and integration tests should be added in the future