-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android SDK 32, 33, 34 #983
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fdc3bfb
add sdks
gpolak 8b6c32f
readmes
gpolak 161ce8f
test extension
gpolak 9a361b3
bumping version
gpolak 63c1a2d
Update signing certificate for Sonatype (#982)
jonathanbaker7 6943ddc
add sdks
gpolak d1ff3ec
readmes
gpolak 9bede58
test extension
gpolak 3c1f882
bumping version
gpolak c53e71a
readme
gpolak 9ecd9a8
back to i3 for tests
gpolak 3d846ee
Merge branch 'georgep_add_sdk_support' of github.com:uber/okbuck into…
gpolak 54bf020
Create secring.gpg
gpolak 689491e
readme
gpolak 2a5ddbc
test extension back to i3
gpolak 3f6bdfe
cleanup gitignore
gpolak 3eceabc
too early to bump
gpolak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps with local testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think there should be a dev flow where there's a local secring. The signings creds should live in $HOME/.gradle which is outside the repo, and the secreing typically sits in a separate user path.
This is fine overall, as it's mostly a no-op. Just more curious on the flow that made this needed.