-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android SDK 32, 33, 34 #983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.54.2 was cut already as the key signing rotation (no code changes). Looks like he just missed the changelog, or technically there was no code change 🤷🏻 , so we'll need to use .54.3.
@tyvsmith bumped the version to 0.54.3 |
* Prepare for release 0.54.2 * Prepare next development version. * Revert gradle.properties
… georgep_add_sdk_support
@@ -16,6 +17,7 @@ buck-out | |||
**/BUCK | |||
|
|||
buildSrc/bintray.properties | |||
buildSrc/secring.gpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps with local testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think there should be a dev flow where there's a local secring. The signings creds should live in $HOME/.gradle which is outside the repo, and the secreing typically sits in a separate user path.
This is fine overall, as it's mostly a no-op. Just more curious on the flow that made this needed.
@tyvsmith, all green now. I didn't update the pre-instrumented version in |
Description: