Handle _buffer_line_data_changed #590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoran
force-pushed
the
handle-buffer-line-data-changed
branch
3 times, most recently
from
86d8f62 to
0815d47
Compare
Fixes some of #577
When buffer is cleared using `/buffer clear` and more lines are added, line pointers may be reused. Before, if the app was disconnected during these events, after reconnection it was possible for the lines to appear out of order. This happened because normally we calculate diff using pointers only, and if we had an older line with the same pointer as the newer one, the adapter would reuse the old view holder, which might've been displaying the wrong line. This fixes the issue by also looking at line contents while diffing. This solution is not ideal: * While we can reliably tell whether the contents of two lines are the same, during the diffing we also want to know whether two lines represent the same thing, even if the contents have changed. As the pointer can be reused, sometimes `areItemsTheSame` will return a false positive. However, with this change the negative effect of this shouldn't go beyond wrong animation being applied. * Read marker may appear in a wrong place. We save the pointer to the last read line locally, and if the pointer is reused, there's no way for us to tell that the line is wrong. Fixes #577
Stable line IDs have been available in hdata for some time, but were not sent in all cases until WeeChat v4.4.0. Parse the line ID into the pointer field for WeeChat > v4.4.0 to improve reliability of line comparisions across the app.
oakkitten
force-pushed
the
handle-buffer-line-data-changed
branch
from
0815d47 to
81f6833
Compare
|
See This removes “Don't animate edited line” and adds “Add a preference to disable handling line changes”. I like adding new preferences as much as the other guy, but there just isn't a simple way to reliably get of jankiness in animations, especially when using scripts such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
_buffer_line_data_changed. Also provides the stable line ID when available and uses this when diffing.Open question: currently this animates a line change asLine edits will not interrupt any running animation, but will also not trigger an animation of their own. Good enough for now?Animation.NewLinesFetched. Is that desirable? Should there be no animation? Some other animation?