-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncronize camera_info with images #38
base: noetic-devel
Are you sure you want to change the base?
Conversation
I think this PR should be extended to allow different resolutions per stream type (probably RGB and SEGMENT should use the same) , justifying the need of individual camera infos. To better replicate real setups. |
Are you sure. Usually, camera_info topics are latched and simply provide a fixed message. Therefore, the timestamp shouldn't be relevant. |
Atleast our cameras do that. By rep-0104
|
442d16f
to
ad25935
Compare
I changed the offscreen_camera to have a The topics are now configurable such that:
is used as default - which should match real camera setups. |
ad25935
to
36b6f99
Compare
previously, in case a render request is still active, freeing the context would case a segfault. Instead now the render mutex is locked, the pending request is canceled and the context freed.
Default build tries the following: If GLFW is found, it will be used for GUI and offscreen rendering. Otherwise GUI functionality is not provided. As fallback for offscreen rendering first GLE is searched, otherwise osmesa. In case neither can be found, offscreen rendering is disabled, too.
* fixes edge case where model was missing fields because of a missing forward computation which caused issues when applying the model to the offscreen scene. * fixes possible deadlock during shutdown when waiting to join the render loop.
36b6f99
to
543b8d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## noetic-devel #38 +/- ##
================================================
- Coverage 59.31% 58.82% -0.48%
================================================
Files 19 19
Lines 2860 2972 +112
Branches 334 323 -11
================================================
+ Hits 1696 1748 +52
- Misses 1164 1224 +60 ☔ View full report in Codecov by Sentry. |
- give each image from cameras its own topic - add configuration for camera topics This changes cameras to publish a syncronized camera_info for each image. e.g for rgb image: /mujoco_server/cameras/camera_name/rgb/camera_info /mujoco_server/cameras/camera_name/rgb/image_raw Additional configuration options to change topics: camera_name/topic: defaults to "/mujoco_server/cameras/camera_name" camera_name/name_rgb: default to "rbg" camera_name/name_depth: default to "depth" camera_name/name_segment: default to "segmented"
543b8d5
to
6f01c4e
Compare
73410d3
to
b8ce3da
Compare
FYI: this is already merged into wip-headless-rendering. And will be available in noetic-devel once we merge the feature branch. |
Description
camera_info needs to have the same timestamp as the images. (e.g. for usage with
message_filters.TimeSynchronizer
)This changes cameras to publish a syncronized camera_info for each image. e.g for rgb image:
/mujoco_server/cameras/camera_name/rgb/camera_info
/mujoco_server/cameras/camera_name/rgb/image_raw
Additional configuration options to change topics:
camera_name/topic
: defaults to "/mujoco_server/cameras/camera_name"camera_name/name_rgb
: default to "rbg"camera_name/name_depth
: default to "depth"camera_name/name_segment
: default to "segmented"Checklist