Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUPS for core contracts #774

Closed
rndquu opened this issue Aug 25, 2023 · 27 comments · Fixed by #779
Closed

Add UUPS for core contracts #774

rndquu opened this issue Aug 25, 2023 · 27 comments · Fixed by #779
Assignees

Comments

@rndquu
Copy link
Member

rndquu commented Aug 25, 2023

Original discussion

Right now we use the diamond proxy pattern for most of our contracts (implemented as diamond facets).

We also have the core contracts that can't be used with the diamond proxy because of function clashing. Hence the different upgradability pattern should be used.

What should be done:

  1. Apply UUPS to the core contracts:
  1. Update deployment script accordingly
  2. Refactor tests for core contracts accordingly

P.S. Although CreditClock exists in the "core" folder it is not a "core" contract. We have plans for moving it to diamond facets.

@Keyrxng
Copy link
Member

Keyrxng commented Aug 25, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Aug 25, 2023

Deadline Sat, 26 Aug 2023 23:15:36 UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 30, 2023

    Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Fri Aug 25 2023 23:15:34 GMT+0000 (Coordinated Universal Time)

    @Keyrxng
    Copy link
    Member

    Keyrxng commented Aug 30, 2023

    chill my friend

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 3, 2023

    Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Wed Aug 30 2023 06:20:14 GMT+0000 (Coordinated Universal Time)

    @ubiquibot ubiquibot bot unassigned Keyrxng Sep 6, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    @Keyrxng - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Wed Aug 30 2023 06:20:14 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    @Keyrxng The time limit for this bounty is on Thu, 07 Sep 2023 08:49:39 UTC

    @ubiquibot ubiquibot bot unassigned Keyrxng Sep 6, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    @Keyrxng - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Wed Aug 30 2023 06:20:14 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    @Keyrxng The time limit for this bounty is on Thu, 07 Sep 2023 08:50:02 UTC

    @ubiquibot ubiquibot bot unassigned Keyrxng Sep 6, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    @Keyrxng - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Wed Aug 30 2023 06:20:14 GMT+0000 (Coordinated Universal Time)

    @rndquu
    Copy link
    Member Author

    rndquu commented Sep 6, 2023

    @Keyrxng I don't know why the bot refuses to assign you to the issue, pls try with the /start command

    @Keyrxng
    Copy link
    Member

    Keyrxng commented Sep 6, 2023

    /start

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 6, 2023

    Deadline Thu, 07 Sep 2023 09:13:37 UTC
    Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
    Tips:
    • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
    • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
    • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

      @Steveantor
      Copy link
      Contributor

      Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Fri Aug 25 2023 23:15:34 GMT+0000 (Coordinated Universal Time)

      There's a linked PR, why the bot isn't picking up?

      @rndquu
      Copy link
      Member Author

      rndquu commented Sep 6, 2023

      Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Fri Aug 25 2023 23:15:34 GMT+0000 (Coordinated Universal Time)

      There's a linked PR, why the bot isn't picking up?

      Hard to say, ubiquity/ubiquibot#729

      @molecula451
      Copy link
      Member

      the bot is a rebel

      @molecula451
      Copy link
      Member

      it looks like keyring it's gonna have this one, albeit it still need more work, let's see

      @ubiquibot
      Copy link

      ubiquibot bot commented Sep 18, 2023

      Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
      Last activity time: Wed Sep 13 2023 17:44:44 GMT+0000 (Coordinated Universal Time)

      @Keyrxng
      Copy link
      Member

      Keyrxng commented Sep 18, 2023

      New review requested

      @ubiquibot
      Copy link

      ubiquibot bot commented Sep 21, 2023

      Task Assignee Reward

      [ CLAIM 200 WXDAI ]

      0xAe5D1F19...33f359765

      If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
      We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

      @ubiquibot
      Copy link

      ubiquibot bot commented Sep 21, 2023

      Task Creator Reward

      rndquu: [ CLAIM 114.4 WXDAI ]

      @0x4007
      Copy link
      Member

      0x4007 commented Sep 21, 2023

      @molecula451 did not receive comment incentives here. Does anybody know why? Hard to tell from my phone perhaps the config is disabled?

      @0xcodercrane can you check the logs in Supabase?

      @ubiquity/software-development RFC

      @0x4007
      Copy link
      Member

      0x4007 commented Sep 21, 2023

      /query @molecula451

      @ubiquibot
      Copy link

      ubiquibot bot commented Sep 21, 2023

      @molecula451's wallet address is 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4 and multiplier is 1

      @0x4007
      Copy link
      Member

      0x4007 commented Sep 21, 2023

      https://gnosisscan.io/tx/0xf7a1413dd82a60715a1f8bcb38b9e7e920e68d9ab5f27a093fd16b4a6a82398e

      @molecula451

      @molecula451
      Copy link
      Member

      molecula451 commented Sep 21, 2023

      /query @molecula451 molecula451

      @ubiquibot
      Copy link

      ubiquibot bot commented Sep 21, 2023

      Invalid syntax for query command
      usage /query @user

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Projects
      None yet
      Development

      Successfully merging a pull request may close this issue.

      5 participants