Add workflow to check that core contracts storage is not corrupted

[rndquu]

Depends on #774

Original idea

When we add UUPS support to the core contracts we should check that storage is not corrupted on each PR. There is a handy action for it.

What should be done

• Add a new workflow that uses the rubilmax/foundry-storage-check action on each PR and push to the development branch when *.sol files have been updated

[gitcoindev]

/start

[ubiquibot]

Task Creator Reward

rndquu: [ CLAIM 40.5 WXDAI ]

[ubiquibot]

Reviewer Rewards

molecula451: [ CLAIM 28.8 WXDAI ]

pavlovcik: [ CLAIM 3.8 WXDAI ]

[molecula451]

the bot didn't generate rewards for assignee here either @pavlovcik

[0x4007]

I assume that it is most likely to time out when it calculates the assignee rewards for some reason

[gitcoindev]

Hi @pavlovcik @rndquu @molecula451 thank you for approving and merging! I see this ticket was not the only one affected, likely a regression from one of the recent bot pull requests. Is there any chance to manually trigger the bot to regenerate the assignee reward ?

[0x4007]

@0xcodercrane either you can push a hot fix or I'll need to manually send payment.

I only ask cause you messaged me today saying you're working on the hot fix.

[gitcoindev]

Hi @pavlovcik is the hotfix available?

[0x4007]

@rndquu is working on it. We just need to open and close the issues again to generate the outstanding payments.

[ubiquibot]

@gitcoindev please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 40.5 WXDAI will be deducted from your next bounty.

[ubiquibot]

Conversation Rewards

gitcoindev: [ CLAIM 29.6 WXDAI ]

molecula451: [ CLAIM 4 WXDAI ]

pavlovcik: [ CLAIM 17.8 WXDAI ]

[ubiquibot]

@gitcoindev please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 40.5 WXDAI will be deducted from your next bounty.

[molecula451]

most likely the bot already savePermit() the permit to DB, this happened at ubiquity/ubiquibot#797

[gitcoindev]

I hope the bot did not save the penalty as well 😆 , it seems to go pretty rogue recently.

[molecula451]

no, it does not, but it shows the penalty because it most likely already saved the permit

[gitcoindev]

Ok, so when it saved the permit before it assumed all done and did not re-generate the assignee reward, just the conversation rewards, interesting...

[molecula451]

No. It did not regenerate because it's already saved to the DB so thats why it Pops the penalty if it's reopen because the bot it's fetching the permit data what it did not was comment that permit here

[molecula451]

Also The bot is referencing a penalty amount based on the creator tasks award of first mention about the rewards not based on the task label i see this is happening in all others too You may see the task is 50 but the bot is saying a penalty of 40.5 referencing to creator awards in this case but not limited to

[0x4007]

/query @gitcoindev

[ubiquibot]

@gitcoindev's wallet address is 0x7e92476D69Ff1377a8b45176b1829C4A5566653a and multiplier is 1

[0x4007]

https://gnosisscan.io/tx/0x3bb0987c3fbe936a8204a90d1b9051bee9264cec9a32a042dec08421fa861a42

[gitcoindev]

@pavlovcik thank you