feat(ui): apply diamond architecture in the credit page

[bojan07]

Resolves #786

[ubiquibot]

• 7e43daa
• cf2a483
• de1b99c
• e111d5b
• c37cc46
• f01e546
• e111d5b

[bojan07]

Files that is applied camel case failed in the ci process

[bojan07]

file names that is applied both camel case and pascal case are failing in the github ci process

[0x4007]

You're using "!" Everywhere which should have been strictly forbidden as part of our lint settings.

[bojan07]

fixed all again

[molecula451]

please, deploy the contracts locally, provide a bit of QA to your code

[bojan07]

please, deploy the contracts locally, provide a bit of QA to your code

What do you mean "QA"?

[bojan07]

please, deploy the contracts locally, provide a bit of QA to your code

Warnings in browser console was generated from Uniswap widget.. not from our codebase

[bojan07]

Also added some logs in usePrices component, and tested

[rndquu]

@bojan07 Could you fix this error?

[bojan07]

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored
What do you think that this error generated from?

[rndquu]

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored What do you think that this error generated from?

It is caused by the <UcrRedeem twapInteger={twapInteger} /> component but I haven't investigated in depth the root cause

[bojan07]

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored What do you think that this error generated from?

It is caused by the <UcrRedeem twapInteger={twapInteger} /> component but I haven't investigated in depth the root cause

Yeah, thanks for your time to check it out

[bojan07]

@bojan07 Could you fix this error?

Just checked in depth. This issue was generated from Uniswap alpha router implementation.. need to check more in depth

[bojan07]

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

[bojan07]

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

[rndquu]

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

[bojan07]

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

After updating uniswap router version to the latest, I'm getting new error.. have you met this kind of error before? I guess that it was because uniswap router only support certain networks(chains), not support local network(chainID 31337)

[bojan07]

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

So, this can be fixed on our codebase? or just uniswap router package issue?

[rndquu]

I guess that it was because uniswap router only support certain networks

Or some API has changed. I don't see any reasons why local networks can't be supported.

So, this can be fixed on our codebase? or just uniswap router package issue?

Hard to say, pls find the root cause of the error and fix it (if possible)

[bojan07]

I guess that it was because uniswap router only support certain networks

Or some API has changed. I don't see any reasons why local networks can't be supported.

So, this can be fixed on our codebase? or just uniswap router package issue?

Hard to say, pls find the root cause of the error and fix it (if possible)

Oh.. already spending time on it.. feeling big issue 🤷‍♀️

[bojan07]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

[bojan07]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

[rndquu]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

[bojan07]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

[rndquu]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

@molecula451 Could you help with this error?

[molecula451]

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

@molecula451 Could you help with this error?

yes I will take a look as a part of the review

[bojan07]

yes I will take a look as a part of the review

Any luck with this?

[bojan07]

While updating from several times of reviews, the work related to credit page was completely reflected to PR804 through the recently added a few commits. so this can be closed to avoid complexity