Fix set role admin #879
Closed
Fix set role admin #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily disable for pull requests until limiting rate API issue is resolved. Reference: ubiquity#876
Temporarily disable for pull requests until limiting rate API issue is resolved. Reference: ubiquity#876
…age-changes-workflow-to-manual chore: temporarily disable storage changes workflow for pull requests
gitcoindev
force-pushed
the
fix-set-role-admin
branch
from
0bdc302
to
3e96286
Compare
|
closing reopening? 😆 |
|
@molecula451 I am sorry for the spam. I was confused and realized too late that we disabled GraphQL and contract storage changes workflows in development branch, but fix-review branch still has it enabled. So it is enabled and still failing here.. |
|
yeah you pointed the disabled to the development branch lol |
The setRoleAdmin can be only accessed by the admin.
gitcoindev
force-pushed
the
fix-set-role-admin
branch
from
3e96286
to
a9df0e2
Compare
|
doesn't look clean, the PR is gathering my commits to this PR, better just re-do the disable |
You are right. Let me clean up this now. I will delete the pr, merge development to fix-review. Then base my pull request on the updated fix-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves sherlock-audit/2023-12-ubiquity-judging#90