chore: Fix review #907
Merged
chore: Fix review #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: deprecate incentive on dollar token
* feat: add setRoleAdmin to AccessControlFacet The setRoleAdmin can be only accessed by the admin. * feat: add setRoleAdmin to AccessControl interface * test: add testSetRoleAdmin_ShouldSetAdminRoleForGivenRole test * feat: update access control for setRoleAdmin * test: fix ShouldSetAdminRoleForGivenRole and add test for revert
feat: add getRedeemCollateralBalance() method
* fix: limit AMO minter borrow amount * test: assert free collateral amount
* feat: implement BlocksInWeek script task The BlocksInWeek task provides a very close approximate of number of blocks mined during one week. Supported networks: mainnnet, sepolia. Example usage: npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet npx tsx scripts/task/task.ts BlocksInWeek --network=sepolia Resolves: sherlock-audit/2023-12-ubiquity-judging#230 * feat: update weekly block count to 49930 Set weekly block count to 49930 as measured in February 2024 npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet ... Calculating number of blocks in the last week... Recent average block time: 12 seconds Estimated blocks in a week best case 50400 Produced 49930 blocks, 470 worst than the best case Resolves: sherlock-audit/2023-12-ubiquity-judging#230 * feat: rename task function to funcBlocksInAWeek As proposed during pull request review.
…-when-collateral-is-equal-to-zero Do not allow to mint dollar when collateral is equal to zero
feat: use CurveStableSwapMetaNG contract
Also add a unit test that verifies the check. Resolves: sherlock-audit/2023-12-ubiquity-judging#29
0x4007
reviewed
Mar 1, 2024
0x4007
reviewed
Mar 1, 2024
gitcoindev
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
I approve from my side as we reviewed this already when merging to fix-review branch. Just reformatting as suggested by @pavlovcik can be done in a separate pull request. About the changed test expected value, will need to check this carefully as well during staking issue investigation.
molecula451
reviewed
Mar 1, 2024
molecula451
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #866
The
Check For Core Contracts Storage Changesworkflow is failing but it's expected since the incentives feature is removed hence the contract's storage layout has been updated