Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix review #907

Merged
merged 26 commits into from
Mar 1, 2024
Merged

chore: Fix review #907

merged 26 commits into from
Mar 1, 2024

Commits on Jan 18, 2024

  1. fix: deprecate incentive on dollar token

    @molecula451
    molecula451 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bb6543e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. chore: update

    @molecula451
    molecula451 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a265481 View commit details
    Browse the repository at this point in the history

  2. chore: update

    @molecula451
    molecula451 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    fc32be5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #875 from molecula451/fix 

    fix: deprecate incentive on dollar token
    @gitcoindev
    gitcoindev authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0772735 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'ubi/development' into fix-review

    @gitcoindev
    gitcoindev committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    43f8d96 View commit details
    Browse the repository at this point in the history

  5. Fix set role admin (#880) 

    * feat: add setRoleAdmin to AccessControlFacet

The setRoleAdmin can be only accessed by the admin.

* feat: add setRoleAdmin to AccessControl interface

* test: add testSetRoleAdmin_ShouldSetAdminRoleForGivenRole test

* feat: update access control for setRoleAdmin

* test: fix ShouldSetAdminRoleForGivenRole and add test for revert
    @gitcoindev
    gitcoindev authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ba8e447 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. feat: add getRedeemCollateralBalance() method

    @rndquu
    rndquu committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    608289e View commit details
    Browse the repository at this point in the history

  2. fix: remove balanced reserves check (#883)

    @rndquu
    rndquu authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b8ed0c3 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #881 from rndquu/feat/view-redeem 

    feat: add getRedeemCollateralBalance() method
    @gitcoindev
    gitcoindev authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    ef7fec9 View commit details
    Browse the repository at this point in the history

  4. fix: limit AMO minter borrow amount (#882) 

    * fix: limit AMO minter borrow amount

* test: assert free collateral amount
    @rndquu
    rndquu authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    46d9d62 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. fix: do not allow to mint dollar with zero collateral 

    Resolves: sherlock-audit/2023-12-ubiquity-judging#207
    @gitcoindev
    gitcoindev committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3f3ffea View commit details
    Browse the repository at this point in the history

  2. test: add testMintDollar_ShouldRevert_IfZeroCollateralAvailable

    @gitcoindev
    gitcoindev committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    33d0fa1 View commit details
    Browse the repository at this point in the history

  3. test: update comment in zero collateral mint test

    @gitcoindev
    gitcoindev committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8efd07f View commit details
    Browse the repository at this point in the history

  4. Update block count in a week (#891) 

    * feat: implement BlocksInWeek script task

The BlocksInWeek task provides a very close approximate of number of
blocks mined during one week.

Supported networks: mainnnet, sepolia.

Example usage:

npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet
npx tsx scripts/task/task.ts BlocksInWeek --network=sepolia

Resolves: sherlock-audit/2023-12-ubiquity-judging#230

* feat: update weekly block count to 49930

Set weekly block count to 49930 as measured in February 2024

npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet
...
Calculating number of blocks in the last week...
Recent average block time: 12 seconds
Estimated blocks in a week best case 50400
Produced 49930 blocks, 470 worst than the best case

Resolves: sherlock-audit/2023-12-ubiquity-judging#230

* feat: rename task function to funcBlocksInAWeek

As proposed during pull request review.
    @gitcoindev
    gitcoindev authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    aa55dad View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge pull request #892 from gitcoindev/do-not-allowed-to-mint-dollar… 

    …-when-collateral-is-equal-to-zero

Do not allow to mint dollar when collateral is equal to zero
    @rndquu
    rndquu authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7035b0a View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. feat: use CurveStableSwapMetaNG contract

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    afa25e8 View commit details
    Browse the repository at this point in the history

  2. refactor: update migrations to use latest metapool

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    fc04416 View commit details
    Browse the repository at this point in the history

  3. refactor: deprecate IMetaPool

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4d47df9 View commit details
    Browse the repository at this point in the history

  4. refactor: remove MockTWAPOracleDollar3pool

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f3e3832 View commit details
    Browse the repository at this point in the history

  5. refactor: remove TWAPOracleDollar3poolFacet

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8a09a4a View commit details
    Browse the repository at this point in the history

  6. refactor: remove MockMetaPool

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4b7c186 View commit details
    Browse the repository at this point in the history

  7. refactor: remove LibTWAPOracle

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d989136 View commit details
    Browse the repository at this point in the history

  8. fix(dapp): remove TWAP oracle ABI import

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d4c55e5 View commit details
    Browse the repository at this point in the history

  9. refactor(frontend): use ICurveStableSwapMetaNG for TWAP

    @rndquu
    rndquu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    81723ce View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge pull request #893 from rndquu/feat/metapool-ng 

    feat: use CurveStableSwapMetaNG contract
    @gitcoindev
    gitcoindev authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    682354e View commit details
    Browse the repository at this point in the history

  2. feat: check if collateral is enabled in collectRedemption (#894) 

    Also add a unit test that verifies the check.

Resolves: sherlock-audit/2023-12-ubiquity-judging#29
    @gitcoindev
    gitcoindev authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5ab280d View commit details
    Browse the repository at this point in the history