Export project interaction details #7513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dredmonds
force-pushed
the
feature/export-interaction-details
branch
from
dd11a6f to
47f258e
Compare
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/export-interaction-details
|
| Run status |
|
| Run duration | 08m 12s |
| Commit |
|
| Committer | Edmond De Los Reyes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
74
|
| View all changes introduced in this branch ↗︎ | |
dredmonds
requested review from
hammadmalik2024,
oliverjwroberts,
elcct,
ince-dbt and
marijnkampf
dredmonds
changed the base branch from
main
to
feature/export-project-interactions
dredmonds
force-pushed
the
feature/export-project-interactions
branch
from
f49e4e4 to
2641753
Compare
dredmonds
force-pushed
the
feature/export-interaction-details
branch
from
47f258e to
c06eeeb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/export-project-interactions #7513 +/- ##
=======================================================================
- Coverage 88.57% 88.56% -0.01%
=======================================================================
Files 1144 1146 +2
Lines 17789 17815 +26
Branches 5097 5106 +9
=======================================================================
+ Hits 15756 15778 +22
- Misses 2033 2037 +4 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dredmonds
force-pushed
the
feature/export-interaction-details
branch
9 times, most recently
from
b6b784b to
6b238d8
Compare
* Layout test scenarios - Sort export project interaction list Sort a default company export interaction list * Added test coverage for company export interaction * Added export interaction collection list test * Update sandbox server `/v4/export/:exportId` endpoint error response * Fix export interaction tab navigation failing test * Moved a constant functions declaration Is a best practice to declare constant functions in the beginning of the codebase before calling, in order the javascript interpreter can locate. This action being reverted and noted as part of flakiness/tech debt. * Use interaction `subject` rather than export `title` Amend the current implementation of export interaction list by using `subject` rather than export interaction `title` on the list because is already on the header and repetitive each details .
dredmonds
force-pushed
the
feature/export-interaction-details
branch
from
6b238d8 to
0ef8e2b
Compare
dredmonds
changed the base branch from
feature/export-project-interactions
to
feature/export-project-interactions-V2
dredmonds
force-pushed
the
feature/export-interaction-details
branch
2 times, most recently
from
f6d4164 to
ea67d1c
Compare
Added test coverage for company export interaction
dredmonds
force-pushed
the
feature/export-interaction-details
branch
from
ea67d1c to
da56e25
Compare
3 tasks
cgsunkel
approved these changes
Feb 11, 2025
DeanElliott96
approved these changes
Feb 11, 2025
dredmonds
force-pushed
the
feature/export-project-interactions-V2
branch
from
8b3663a to
110857c
Compare
dredmonds
force-pushed
the
feature/export-interaction-details
branch
from
da56e25 to
1a1e592
Compare
dredmonds
merged commit 5a4a709
into
feature/export-project-interactions-V2
2 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As part of Export project interaction feature, this PR allows to display export project details using this front-end url path:
/export/{id}/details.Test instructions
Using sandbox, navigate into this page
http://localhost:3000/export/f5bc555e-0eba-4a7e-abe9-db89a78afc5c/detailsit render export project details page and providing essential information.Screenshots
Before
Export project interaction details
After
New export project interaction details
Checklist