UAT release #2326
Merged
UAT release #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Units is not actually a model but we want the response to be paginated similar to other endpoints so that metadata endpoint can correctly expose this to DW.
…_licences_endpoint Add goods on licences endpoint
LTD-5673: Productionise goods ratings endpoint
…s-endpoint LTD-5688: Productionise footnotes endpoint
LTD: Productionise units endpoint
…-to-licence-decision Add denial reasons to licence decision
…decision-refusals-criteria Ltd 5680 productionise licence decision refusals criteria
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| data[f"quantity-{good_on_app.id}"] = str(good_on_app.quantity) | ||
| data[f"value-{good_on_app.id}"] = str(good_on_app.value) | ||
| # create final advice for controlled goods; skip NLR goods | ||
| if good_on_app.is_good_controlled == False: |
There was a problem hiding this comment.
Suggested change
| if good_on_app.is_good_controlled == False: | |
| if good_on_app.is_good_controlled is False: |
False is a singleton data type, so should be compared using is. More.
markj0hnst0n
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
LTD-