-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAT release #2326
Merged
+816
−265
Merged
UAT release #2326
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
09e4651
Add endpoint for goods descriptions
kevincarrogan f7082be
Add an assessments table
kevincarrogan cbc2fd1
Add bdd tests for goods ratings endpoint
saruniitr f16a45d
Merge branch 'dev' into LTD-5673-goods-ratings-endpoint
saruniitr 4a0fe69
Merge branch 'dev' into LTD-5673-goods-ratings-endpoint
saruniitr e8492c8
Add footnotes table
kevincarrogan 26ade23
Add bdd tests for footnotes endpoint
saruniitr 288b355
Add unit viewset
kevincarrogan 574744b
Add proper 404 for unfound unit
kevincarrogan 923291e
Add bdd tests for units endpoint
saruniitr 78f96e3
Order goods_rating table by the rating
saruniitr 78f88f3
Merge branch 'dev' into LTD-5673-goods-ratings-endpoint
saruniitr fb4ef21
Add goods on licences endpoint initial commit
hnryjmes 47924e0
Add table_name
hnryjmes 2170459
Add test for issuing a licence
hnryjmes cb1c1e2
Add test for NLR goods not appearing in goods on licences table
hnryjmes 807d0a0
Add test for draft licences and draft applications
hnryjmes 415390d
Update units endpoint to return the response similar to other endpoints
saruniitr 5d9e50e
Remove unused imports
saruniitr 63c3b5a
Merge pull request #2307 from uktrade/LTD-5674_Productionise_goods_on…
hnryjmes 666e139
Merge branch 'dev' into LTD-5673-goods-ratings-endpoint
saruniitr 6a2824f
Merge pull request #2311 from uktrade/LTD-5673-goods-ratings-endpoint
saruniitr b59e46f
Merge branch 'dev' into LTD-5688-productionise-footnotes-endpoint
saruniitr 3c0e805
Merge pull request #2318 from uktrade/LTD-5688-productionise-footnote…
saruniitr a76bd0c
Merge branch 'dev' into LTD-productionise-units-endpoint
saruniitr 96f21b6
Merge pull request #2319 from uktrade/LTD-productionise-units-endpoint
saruniitr f80613b
Add denial reasons to licence decision
kevincarrogan d952e00
Stop passing through request to case model in finalise
kevincarrogan 9b4a537
Remove merge migration
kevincarrogan a6e2788
Merge pull request #2308 from uktrade/LTD-5682-attach-refusal-reasons…
kevincarrogan 18ec33a
Add licence refusal criteria endpoint
kevincarrogan b5224e1
fixup
kevincarrogan fabe60d
fixup
kevincarrogan 8accc65
Merge pull request #2310 from uktrade/LTD-5680-productionise-licence-…
kevincarrogan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test for NLR goods not appearing in goods on licences table
commit cb1c1e2fcf3ff4285ca2dd6923c1cd6f622ef914
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False
is a singleton data type, so should be compared usingis
. More.