Feature: Simpler app language request #18278
Open
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I am not sure we can remove the isAuthorized check. Isn't it used when a user gets automatically logged out and then logs in again (through the pop-up window)?
Unfortunately, this is something we need to do for all requests, so we need to come up with a better solution at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing isAuthorized observation as it is not needed any longer, cause it seems that the whole application refreshes if a new user is logged in. (If you log in with the same user it does not refresh)
Please make sure to test in not on a front-end developer server, cause thats what I did, and therefor this assumption may not be right.
In code you will notice that this also comes with a new observation and get method.