-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/pcgr v2.2.1 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… during annotation must be above 1 and not more than 8 (recommended is 4)"
bolt/common/pcgr.py
Outdated
import re | ||
import shutil | ||
import tempfile | ||
import gzip # added import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove inline comment, and preferably order alphabetically!
Nice work! I'm seeing a test failure, any thoughts what might be causing that? Run python3 -m unittest discover tests/ --buffer
.F............
======================================================================
FAIL: test_clinical_potential_rescue_general (test_smlv_somatic_filter.TestSmlvSomaticFilter)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/bolt/bolt/tests/test_smlv_somatic_filter.py", line 204, in test_clinical_potential_rescue_general
assert not record.FILTER
AssertionError |
I added |
The idea of this specific test is to simulate variants that were going to be filtered but are saved by what I've called 'clinical potential' rescue. This means that the output variants should have Since the conditions for the 'clinical potential' rescue has changed in this PR (i.e. removal of COSMIC and ICGC-PCAWG conditionals) the existing test variants that relied on those criteria failed. I've updated the test to align with the new conditions for this rescue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me!
Update Bolt to work with pcgr v2.2.1
link with sash PR#17