Skip to content

Conversation

qclayssen
Copy link
Collaborator

@qclayssen qclayssen commented Aug 19, 2025

Update Bolt to work with pcgr v2.2.1

link with sash PR#17

@qclayssen qclayssen requested review from pdiakumis and scwatts August 26, 2025 06:13
@qclayssen qclayssen self-assigned this Aug 26, 2025
@qclayssen qclayssen added the enhancement New feature or request label Aug 26, 2025
@qclayssen qclayssen marked this pull request as ready for review August 26, 2025 06:14
import re
import shutil
import tempfile
import gzip # added import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove inline comment, and preferably order alphabetically!

@scwatts
Copy link
Member

scwatts commented Aug 28, 2025

Nice work!

I'm seeing a test failure, any thoughts what might be causing that?

Run python3 -m unittest discover tests/ --buffer
.F............
======================================================================
FAIL: test_clinical_potential_rescue_general (test_smlv_somatic_filter.TestSmlvSomaticFilter)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/bolt/bolt/tests/test_smlv_somatic_filter.py", line 204, in test_clinical_potential_rescue_general
    assert not record.FILTER
AssertionError

@qclayssen
Copy link
Collaborator Author

Nice work!

I'm seeing a test failure, any thoughts what might be causing that?

Run python3 -m unittest discover tests/ --buffer
.F............
======================================================================
FAIL: test_clinical_potential_rescue_general (test_smlv_somatic_filter.TestSmlvSomaticFilter)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/bolt/bolt/tests/test_smlv_somatic_filter.py", line 204, in test_clinical_potential_rescue_general
    assert not record.FILTER
AssertionError

I added Filter column in the final TSV, because it uses in gpgr for breakend pairing, see gprg issue. And this test specifically, it's not in there. i'm removing this test

@scwatts
Copy link
Member

scwatts commented Aug 28, 2025

The idea of this specific test is to simulate variants that were going to be filtered but are saved by what I've called 'clinical potential' rescue. This means that the output variants should have FILTER cleared / emptied and INFO containing the appropriate rescue flag

Since the conditions for the 'clinical potential' rescue has changed in this PR (i.e. removal of COSMIC and ICGC-PCAWG conditionals) the existing test variants that relied on those criteria failed. I've updated the test to align with the new conditions for this rescue

Copy link
Member

@scwatts scwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@qclayssen qclayssen merged commit 033bcf8 into release/0.3.0 Sep 2, 2025
2 checks passed
qclayssen added a commit that referenced this pull request Sep 15, 2025
@qclayssen qclayssen mentioned this pull request Sep 15, 2025
qclayssen added a commit that referenced this pull request Oct 2, 2025
qclayssen added a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants