remove api call ID prefix for db CRUD #105
Conversation
| @@ -17,7 +17,7 @@ const SequenceRunDetailsDrawer: FC<SequenceRunDetailsDrawerProps> = ({ | |||
|
|
|||
| const { data: sequenceRunDetail, isFetching: isFetchingSequenceRunDetail } = | |||
| useSequenceRunDetailModel({ | |||
| params: { path: { id: selectedSequenceRunId } }, | |||
| params: { path: { id: selectedSequenceRunId?.split('.')[1] as string } }, | |||
There was a problem hiding this comment.
So this stripped the prefix out (leaving just the ULID)? umccr/orcabus#784 should basically do that so the FE don't need to this anymore.
There was a problem hiding this comment.
Unless there is a bug from that PR? But from testing in https://sequence.dev.umccr.org/schema/swagger-ui/# it does seems work with or without the prefixes
There was a problem hiding this comment.
yes, FE will need the prefix+ULID in its url for page pathway, not for api call. when make api call, ULID will be enough to find the instance. Not sure for all, but for sequence and workflow manager, so far is okay
There was a problem hiding this comment.
Unless there is a bug from that PR? But from testing in https://sequence.dev.umccr.org/schema/swagger-ui/# it does seems work with or without the prefixes
And also I remove the prefix because there will a conflict like this when make api call with prefix when saving the association_id. If we keep consistency when make api call with out prefix, no conflict and no need to touch BE code
There was a problem hiding this comment.
The fix here is for the API call not for FE page pathway? So the strip here makes no difference in the results?
FE will need the prefix+ULID in its url for page pathway,
Why the FE would need the prefix? Should it just pass the ID through the API?
There was a problem hiding this comment.
yes, actually FE don't need the prefix as well, just take it directly from db read. I will have a think to remove it all...
There was a problem hiding this comment.
And also I remove the prefix because there will a conflict like this when make api call with prefix when saving the association_id. If we keep consistency when make api call with out prefix, no conflict and no need to touch BE code
I think the logic should then be in BE so that any client using the API should not care about this? Perhaps if think we could just change this association_id to become OrcaBusIdField instead of CharField then the stripping will be handled automatically.
|
As discussed, couple with db field change to "OrcaBusIdField" umccr/orcabus#820 |
|
wait to be revert as fix PR in bacnkend here |
Fix #104 and umccr/orcabus#818
Reason: api call update according umccr/orcabus#784 and remove prefix for overall consistency in api call with db