Feat/workflow run module refactor #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, since the dataset option would only be one input, do you think it would be better to have a sorted dropdown instead? |
|
yes, I think that before, but it seems not that clear, so I just list them all out, but we can still just select one of them, not multi select I am think if we can group them by "# PRIMARY_DATASETS_OPTION" "# EXTENDED_DATASETS_OPTION" "# PAN_CANCER_DATASETS_OPTION", and use Disclosure/Accordion to list them, so bit more clear and order |
williamputraintan
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow details page refactor
related #74
dropdown btn for rerun:
rerun dialog :
comment dialog:
state dialog:
couple with backend logic of 'DEPRECATED" umccr/orcabus#770