Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event source name rule should be an array #112

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: event source name rule should be an array #112

merged 1 commit into from
Feb 21, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Feb 21, 2024 •
edited
Loading

Closes #111

Changes

  • Convert EventSource name rule to array.

@mmalenic mmalenic self-assigned this Feb 21, 2024
victorskl
victorskl approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! (Flo and me found the other day. Forget to mention...)

@mmalenic mmalenic merged commit f7d3439 into main Feb 21, 2024
2 checks passed
@mmalenic mmalenic deleted the fix/event-source branch February 21, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamputraintan williamputraintan williamputraintan approved these changes

@victorskl victorskl victorskl approved these changes

Assignees

@mmalenic mmalenic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event source rules are not valid
3 participants
@mmalenic @victorskl @williamputraintan