Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Manager Enhancement #149

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Postgres Manager Enhancement #149

merged 3 commits into from
Mar 13, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Mar 12, 2024

  • Modify the credential name for microservice secret
    from orcabus/microservice/${microserviceName} to orcabus/${microserviceName}/RdsLoginCredential - i think the name makes more sense to what it is used for, as each microservice might have its own secret

@williamputraintan williamputraintan changed the title rename credential Postgres Manager Enhancement Mar 12, 2024
@williamputraintan
Copy link
Member Author

currently deployed in dev @pdiakumis @victorskl @reisingerf @mmalenic

@victorskl
Copy link
Member

Yup, this makes sense, Will.

Pls remember to create a GH ticket (or reuse existing one as see fit, pls)

@williamputraintan williamputraintan marked this pull request as ready for review March 13, 2024 00:52
@victorskl victorskl added the fix label Mar 13, 2024
@victorskl victorskl linked an issue Mar 13, 2024 that may be closed by this pull request
@williamputraintan williamputraintan merged commit 1ce799b into main Mar 13, 2024
2 checks passed
@williamputraintan williamputraintan deleted the fix/postgres-manager branch March 13, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform CodePipeline chores
2 participants