Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filemanager): silence Makefile output and trim lines #187

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

mmalenic
Copy link
Member

Related to #180, #183, #184 and #169.

Hopefully this is the last of these, this time making sure by running tests using local CodeBuild.

@mmalenic mmalenic self-assigned this Mar 25, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager fix labels Mar 25, 2024
@mmalenic mmalenic requested a review from victorskl March 25, 2024 23:17
@victorskl victorskl linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there... 👍

@victorskl
Copy link
Member

using local CodeBuild

Perhaps, check it out the codebuild-breakpoint technique that mentioned in #162 at some point in time.

@mmalenic mmalenic force-pushed the fix/docker-container-name branch 4 times, most recently from 534bb0e to e344aff Compare March 27, 2024 02:33
@mmalenic mmalenic force-pushed the fix/docker-container-name branch from e344aff to 2d46997 Compare March 27, 2024 02:38
@mmalenic mmalenic merged commit 9c8c806 into main Mar 27, 2024
2 checks passed
@mmalenic mmalenic deleted the fix/docker-container-name branch March 27, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: reconfigure deployment to match other microservices
2 participants