chore: remove parent (of µ-app) stack in cdk.Stage and Refactor
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,36 +53,57 @@ export class Filemanager extends Stack { | |||
| constructor(scope: Construct, id: string, props: FilemanagerProps) { | |||
There was a problem hiding this comment.
@mmalenic I made tweaks on the Filemanager Props here so that the lookup is now done within the stack. So this stack can independently run without depending on other stack. Perhaps I need a pair of eye if I did this correctly.
williamputraintan
requested review from
victorskl,
reisingerf,
brainstorm and
mmalenic
victorskl
approved these changes
Apr 15, 2024
mmalenic
approved these changes
Apr 16, 2024
Comment on lines
76
to
77
| buildEnvironment: {}, | ||
| // rustLog: props?.rustLog, |
There was a problem hiding this comment.
You can remove these two properties, currently they aren't being used but I'll add back in if needed.
Comment on lines
105
to
106
| buildEnvironment: {}, | ||
| // rustLog: props?.rustLog, |
reisingerf
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove intermediary stack between stage and µ-app stack
Lookup on shared resource is move to individual stack
Refactoring naming convention for TS