chore: Pipeline Refactor

[williamputraintan]

• Change stage ConstructId name
• Migrate build notification to alerts-build
• Change AccountName to AppStage name for consistency

[victorskl]

reviewing...

[victorskl]

Ah ok, this one is refactor. At least, #250 #115 merge first. The rest branches have to rebase. Let check with the team.

[williamputraintan]

Happy to merge this after those PR are merged!

[williamputraintan]

As this require redeployment, I am also happy to wait if anyone has any objection and wanted to postpone this for later.

[raylrui]

LGTM!

[victorskl]

@alexiswl This refactor PR can go? And, so that we all follow up rebase onto main after, ok?

[alexiswl]

Sure

[raylrui]

Hi @williamputraintan the conflict comes from our talk before, of the account id alias.

[williamputraintan]

Redeploying ...

[reisingerf]

Not sure if it makes sense to include the following here, but we discussed the option to retrieve constants given a stage rather than using individual constants for that.

E.g. we define 3 constants to look up the ica token here.

Then consumers have to decide which one to use for each stage when defining their config, like here.

We could make that simpler with a common function in the constants that works out which parameter to return given the stage. Something like:
getIcav2AccessTokenSecretName(stage: AppStage)

It would make the consumer config easier and independent of stage definition/changes.

What do you think?

[williamputraintan]

Yeah, think make sense as well to include here. Will follow the pattern with the accountId