feat: basic filemanager query API #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
added
filemanager
…-queries # Conflicts: # lib/workload/stateless/stacks/filemanager/filemanager-build/src/gen_entities.rs # lib/workload/stateless/stacks/filemanager/filemanager-build/src/lib.rs
victorskl
approved these changes
Jun 28, 2024
brainstorm
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315
Related to #110
Depends on #357 (Merging into that branch for now so that viewing this PR is easier).
Changes
Rename object table to object_group to better represent it's purpose.object/s3_object, and fetch anobject/s3_objectby id.filemanager-build, and then used by sqlx infilemanagerto achieve compile time query checking, although I think this probably won't be worth the effort. The sea-orm library is much less likely to produce queries that are invalid, and any issues should be caught at test time anyway. However, I will look into this.Todo (in a different PR)