Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filemanager): Dockerfile caching layer and debug build #442

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Aug 1, 2024

This is in relation to #429.

Changes

  • Fixes the Dockerfile definition which was caching dependency compilations for a debug target, when the main filemanager build was release.
    • All targets now use debug.
    • This halved my compilation times because now things aren't compiling twice accidentally.

Initially I had this compiling release because of embedded files in swagger UI: https://github.com/juhaku/utoipa?tab=readme-ov-file#swagger-ui-returns-404-notfound-from-built-binary. Instead, it's now compiling as debug with the debug-embed flag enabled for utoipa-swagger-ui, which should be faster.

@mmalenic mmalenic self-assigned this Aug 1, 2024
@mmalenic mmalenic added the devops label Aug 1, 2024
@mmalenic mmalenic linked an issue Aug 1, 2024 that may be closed by this pull request
@mmalenic mmalenic added the bug Something isn't working label Aug 1, 2024
@mmalenic mmalenic merged commit 7b46d17 into main Aug 1, 2024
5 checks passed
@mmalenic mmalenic deleted the feat/filemanager-local-api branch August 1, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup SQL Dump/Reload in Local Development
3 participants