Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for linked libraries to WRSC event schema #503

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add support for linked libraries to WRSC event schema #503

merged 1 commit into from
Aug 20, 2024

Conversation

reisingerf
Copy link
Member

This is a new convention to support the linking of workflow runs to libraries.

The association currently has to be supported by the execution services / stacky glues that have that information, as the workflow manager does not have access to it atm.
Also, the workflow manager currently relies on the WRSC event to establish the library association, including the libraryId (from the lab metadata) and the corresponding orcabusId (from the metadata manager). This is expected to be relaxed once we have a different mechanism of updating the workflow manager (e.g. LibraryStateChange events).

@raylrui @williamputraintan

For now this addition is optional as to not break any existing implementations. However, it would be great if we could adopt this wherever possible.

@victorskl victorskl added feature New feature documentation Improvements or additions to documentation labels Aug 20, 2024
@victorskl victorskl linked an issue Aug 20, 2024 that may be closed by this pull request
Add capability for workflow manager to link workflows to libraries #463
Closed
victorskl
victorskl approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexiswl
Copy link
Member

Looks great!

Where can we link the orcabus id and corresponding library id?

Currently I get a 404 on the development library API endpoint?

export ORCABUS_TOKEN="$(  \
  aws secretsmanager get-secret-value \
    --secret-id orcabus/token-service-jwt \
    --query 'SecretString' \
    --output text | \
    jq --raw-output '.id_token' \
)"

curl --silent --show-error --location --fail-with-body \
 --header "Authorization: Bearer $ORCABUS_TOKEN" \
 --url "https://metadata.dev.umccr.org/library?rowsPerPage=1000"

Gives

<!doctype html>
<html lang="en">
<head>
  <title>Not Found</title>
</head>
<body>
  <h1>Not Found</h1><p>The requested resource was not found on this server.</p>
</body>
</html>
curl: (22) The requested URL returned error: 404

@reisingerf
Copy link
Member Author

Due to the change to include /api/v1/ to the endpoint path.

So use https://metadata.dev.umccr.org/api/v1/library

@reisingerf
Copy link
Member Author

The addition of the orcabus_id is still pending I guess. We just introduced this...

@victorskl
Copy link
Member

Where can we link the orcabus id and corresponding library id?

We get it from Metadata Manager, yes.

@williamputraintan is working on it as part of id refactor ticket #470

@reisingerf reisingerf merged commit 4f7d70e into main Aug 20, 2024
5 checks passed
@reisingerf reisingerf deleted the update/WRSC-add-linked-libraries branch August 20, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexiswl alexiswl alexiswl approved these changes

@victorskl victorskl victorskl approved these changes

Assignees

@reisingerf reisingerf

Labels
documentation Improvements or additions to documentation feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capability for workflow manager to link workflows to libraries
3 participants
@reisingerf @alexiswl @victorskl