fix: filemanager migration #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #460 and #514
Issue
The migration Lambda function timed out because the migration involved index creation which can take a while.
Changes
UPDATE_ROLLBACK_FAILED.CloudFormationCustomResourceRequestfrom thelambda-runtime.The migration from #514 doesn't take that long (only about 30 seconds), so for now the simplest solution is to increase the Lambda timeout. Later, it might be an issue if there are any long-running index creation steps.
A better solution could involve:
isCompletehandler from the provider framework.