Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (MM): Library synchronisation issue #542

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Sep 13, 2024

Since sync usually specifies per year level. It will now only allow deletion records in the library model. The deletion will also have additional criteria where it only compares libraries based on the library prefix year.

This PR is changing the behaviour described in this part of the readme:

2. The tracking sheet is the single source of truth for the current year. Any deletion or update to existing records
   will be applied based on their internal IDs (`library_id`, `specimen_id`, and `subject_id`). For the library
   model, the deletion will only occur based on the current year's prefix. For example, syncing the 2024 tracking
   sheet will only query libraries with `library_id` starting with `L24` to determine whether to delete it.

@victorskl victorskl linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix, Will. LGTM. Let give this a shot.!

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound ok to me

@williamputraintan williamputraintan merged commit 0530e02 into main Sep 13, 2024
6 checks passed
@williamputraintan williamputraintan deleted the fix(mm)/no-record-deletion branch September 13, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata-manager: Id refactoring
3 participants