feat(filemanager): accept multiple keys in API #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
added
feature
| curl -H "Authorization: Bearer $TOKEN" "https://file.dev.umccr.org/api/v1/s3?bucket[]=bucket1&bucket[]=bucket2" | jq | ||
| ``` | ||
|
|
||
| Note that the extra `[]` is required in the query parameters to specify multiple keys with the same name. Multiple keys |
There was a problem hiding this comment.
What is the reason behind it where it needs to have the [] for a multiple key? Will this be mutually exclusive with the params that does not have the []? Say ...s3?bucket=bucket1&bucket[]=bucket2 is not possible?
There was a problem hiding this comment.
It's required in the library that parses the query string: https://github.com/samscott89/serde_qs. I think the choice by the author has to do with matching the style of ruby on rails.
Yes, this is mutually exclusive, you can't combine keys with [] and without it.
For example, this works:
/api/v1/s3?key=.../api/v1/s3?key[]=.../api/v1/s3?key[]=...&key[]=...
But this results in an error:
/api/v1/s3?key=...&key[]=...
victorskl
approved these changes
Oct 8, 2024
williamputraintan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #595
Changes
orstatement in the SQL query.[]syntax to specify a list. E.g./api/v1/s3?key[]=key1&key[]=key2.orcondition.