Feature/analysis journey #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OrcaBus ID
reisingerf
requested review from
victorskl,
alexiswl,
williamputraintan and
raylrui
|
.. reviewing |
williamputraintan
approved these changes
Oct 11, 2024
|
|
||
| def to_dict(self): | ||
| return { | ||
| "id": self.id, | ||
| "workflow_run_id": self.workflow_run.id, | ||
| "orcabusId": self.orcabus_id, |
There was a problem hiding this comment.
Should this be snake_case?
There was a problem hiding this comment.
Fair enough. Not even sure those methods are needed at all.
I'll just remove them.
| pk = pk[len(self.orcabus_id_prefix):] | ||
|
|
||
| print("DEBUG: self.queryset") | ||
| print(self.queryset) |
There was a problem hiding this comment.
remove print? or is it intended?
There was a problem hiding this comment.
Good point!
I cleaned up the debug/logging statements a bit.
victorskl
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some breaking changes, like the change from internal auto-id fields to OrcaBus IDs as PKs.
There are also updates to the API with removed/added endpoints and updated/extended response schemas.