feat(filemanager): docker caching and current state default #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng parameters with special meaning inside the `/s3/attributes` route.
…-sscache-in-docker # Conflicts: # lib/workload/stateless/stacks/filemanager/filemanager/src/routes/list.rs
mmalenic
force-pushed
the
feat/filemanager-sscache-in-docker
branch
2 times, most recently
from
84f70a7 to
a7b6b79
Compare
brainstorm
approved these changes
Oct 13, 2024
victorskl
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #600
Changes
Dockerfile, which uses a buildx cache mount to utilize a global cache across different build contexts (like CDK synth, or the fmannotator testcontainers code).currentStatetrue by default in the filemanager API./s3/attributesroute which wasn't taking into account known parameters likecurrentStateorpage.docker compose downis called.