Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filemanager): resetting current state should include old verisons #616

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Oct 25, 2024

Related to #614 and #615.

Changes

  • Fixes the reset current state logic to include old versions of objects.
    • Now, when the query is executed, it flips is_current_state to false for old versions of objects too. Previously this was keeping every versioned object as "current".

I realised that versioned objects need to be reset in the is_current_state query too, because old versions of objects do not represent current state (thanks @reisingerf with this comment).

Performance is similar for this query as it was when version_id was included in the where clause. Note that I don't think there will be many more objects included in the set. Only one copy of a bucket/key combination should be included because the query only needs to check objects with is_current_state = true.

@mmalenic mmalenic self-assigned this Oct 25, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager fix labels Oct 25, 2024
@mmalenic mmalenic merged commit e4ebd26 into main Oct 25, 2024
6 checks passed
@mmalenic mmalenic deleted the feat/filemanager-partitions branch October 25, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants