fix(filemanager): resetting current state should include old verisons #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #614 and #615.
Changes
is_current_state
to false for old versions of objects too. Previously this was keeping every versioned object as "current".I realised that versioned objects need to be reset in the
is_current_state
query too, because old versions of objects do not represent current state (thanks @reisingerf with this comment).Performance is similar for this query as it was when
version_id
was included in thewhere
clause. Note that I don't think there will be many more objects included in the set. Only one copy of a bucket/key combination should be included because the query only needs to check objects withis_current_state = true
.