feat(event-source): ignore cache directories #621
Conversation
… and deleted events
| @@ -94,9 +94,12 @@ const getEventSourceConstructProps = (stage: AppStage): EventSourceProps => { | |||
| rules: [ | |||
| { | |||
| bucket: oncoanalyserBucket[stage], | |||
| eventTypes: ['Object Created', 'Object Deleted'], | |||
There was a problem hiding this comment.
Are those the only event types the FileManager is currently monitoring?
If yes, that's OK, just be aware that this is a while-listing and you'll miss any other events (which is OK for the portal use case, but you'll have to judge if it's also OK for the FileManager).
There was a problem hiding this comment.
Yep, those are the only ones considered right now. It derives all the other information from HeadObject and GetObjectTagging. In the future, I can add support for "Object Storage Class Changed" and "Object Tags Added" to avoid using an API call.
There was a problem hiding this comment.
Sound good. Go for it, Marko. Pls merge when you ready.
There was a problem hiding this comment.
Adding to this issue: #322 (comment)
Related to umccr/infrastructure#489
Changes
byob-icav2when processing incoming EventBridge events, and only forwardCreatedandDeletedevents to filemanager.