Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix(authorization-manager): Sanitize Authorization Header #661

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Nov 7, 2024

allow Bearer prefix on the admin authorisation lambda

Related #617

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good.!

@williamputraintan
Copy link
Member Author

Also, rename the lambda jwt authoriser so it does not contain the admin (policy) naming. The lambda authoriser shouldn't care about the policy (as verified permission should check against it), it should just check the JWT with the given policy Id.

@williamputraintan williamputraintan merged commit 1685210 into main Nov 7, 2024
6 checks passed
@williamputraintan williamputraintan deleted the hotfix/sanitize-authorisation-header branch November 7, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants