Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fmannotator): add DLQ for fmannotator function #664

Merged
merged 6 commits into from
Nov 8, 2024
Merged

feat(fmannotator): add DLQ for fmannotator function #664

merged 6 commits into from
Nov 8, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Nov 7, 2024

Closes #663

Changes

  • Add a DLQ for the FMAnnotator to track if any WorkflowRunStateChange events could not be processed.

@mmalenic mmalenic requested a review from victorskl November 7, 2024 05:52
@mmalenic mmalenic self-assigned this Nov 7, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager feature New feature labels Nov 7, 2024
@mmalenic mmalenic changed the title fix(fmannotator): add DLQ for fmannotator function feat(fmannotator): add DLQ for fmannotator function Nov 7, 2024
victorskl
victorskl approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mmalenic
Copy link
Member Author

mmalenic commented Nov 7, 2024

Update

  • Also adding ability to trigger portalRunId update function manually because SQS queue cannot redrive directly into a Lambda function.

@mmalenic mmalenic force-pushed the fix/fmannotator-dlq branch from d051089 to 115fe84 Compare November 7, 2024 23:59
@mmalenic mmalenic requested a review from victorskl November 8, 2024 00:07
@mmalenic mmalenic merged commit cfe735f into main Nov 8, 2024
6 checks passed
@mmalenic mmalenic deleted the fix/fmannotator-dlq branch November 8, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@mmalenic mmalenic

Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: DLQ for fmannotator
2 participants
@mmalenic @victorskl