Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(filemanager): add permissions that allow API/inventory functions to access pipeline-*-cache buckets #670

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Nov 8, 2024

Closes #669

Changes

  • Gives the API and inventory functions access the orcabus_file_manager_ingest_access role. This allows the API function to create valid presigned URLs, and the inventory function to correctly get object metadata before ingesting.

@mmalenic mmalenic self-assigned this Nov 8, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager fix labels Nov 8, 2024
@mmalenic mmalenic requested a review from victorskl November 8, 2024 02:18
@mmalenic
Copy link
Member Author

mmalenic commented Nov 8, 2024

@williamputraintan This should fix the issue with generating download links in the UI.

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalenic mmalenic merged commit c2f1418 into main Nov 8, 2024
6 checks passed
@mmalenic mmalenic deleted the fix/filemanager-api-permissions branch November 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: fix presigned URLs for objects under pipeline-*-cache buckets
2 participants